quantumlib / Qualtran

Qᴜᴀʟᴛʀᴀɴ is a Python library for expressing and analyzing Fault Tolerant Quantum algorithms.
https://qualtran.readthedocs.io/en/latest/
Apache License 2.0
173 stars 40 forks source link

Improve support for QFxp in classical simulation #1095

Closed NoureldinYosri closed 2 months ago

NoureldinYosri commented 3 months ago

Classical simulation protocol assumes values are always integer as seen by the type hint https://github.com/quantumlib/Qualtran/blob/c6aa41980b6d27a9a1395448dbcab297b87540f7/qualtran/simulation/classical_sim.py#L37

however float values can happen when using QFxp dtype.

fdmalone commented 3 months ago

xref #859

anurudhp commented 2 months ago

1215 adds support for QDType specific values, and #1219 can be used to track ideas for classical representations of QFxp values.