Use `PRGA` in double factorization `ProgRotGateArray`

quantumlib / Qualtran

Qᴜᴀʟᴛʀᴀɴ is a Python library for expressing and analyzing Fault Tolerant Quantum algorithms.

https://qualtran.readthedocs.io/en/latest/

Apache License 2.0

180 stars 48 forks source link

Use `PRGA` in double factorization `ProgRotGateArray` #1319

Open anurudhp opened 3 months ago

anurudhp commented 3 months ago

https://github.com/quantumlib/Qualtran/blob/683472a25a1bafb64fd5e5c58f79405737a4afd4/qualtran/bloqs/chemistry/df/select_bloq.py#L30-L33

fdmalone commented 3 months ago

I don't think this is actually equivalent. PRGA acts on a single target but this one needs to act on multiple targets. Ideally would be unified with the THC bloq (xref: #573).

fdmalone commented 3 months ago

Perhaps an intermediate step would be to not name this ProgRotGateArray and use something like #579 which may be a lot closer to having a real implementation given all the work on phase gradient rotations etc.