quantumlib / ReCirq

Research using Cirq!
https://quantumai.google/cirq/experiments
Apache License 2.0
274 stars 117 forks source link

fermi_hubbard publication_test is not hermetic #165

Open weinstein opened 3 years ago

weinstein commented 3 years ago

it downloads datasets from https://datadryad.org/stash/dataset/doi:10.5061/dryad.crjdfn32v the download URLs are not super stable, but also datadryad.org website unavailability can cause the recirq test suites to flake out and fail

It may be better to avoid the external dependency on datadryad.org in tests and mock out the download.

rmlarose commented 3 years ago

Documenting discussion with the helpful folks at Dryad:

Our team has confirmed that individual files do not have their own unique link. Previously, the did but that was changed with the relaunch in 2019.

So a permanent fix should use the DOI of the dataset instead of URLs for individual files.