Closed mpharrigan closed 2 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
If so, I wonder if it makes more sense to just add this on as a section at the end of the analysis notebook. This would flow better and also get rid of some of the redundant code.
While there is some redundancy, I see this notebook as solving a completely different use case than the other one. The walkthrough is designed to give the developer some insight into the at times complicated aggregation routines available in the analysis module. It's necessary reading if you want to contribute a new way of slicing and dicing the data.
This other notebook is the final step in routine execution of the algorithmic benchmark. I must admit I have a preference for small, focused notebooks over big ones; but here are some real reasons:
plots.ipynb
since it's part of the normal user flow. Documentation-style notebooks will be added as necessary alongside if there's something that needs to be explainedplots
notebook by hand. 1) it can be run headlessly and upload the images somewhere 2) it can be copied into some actual dashboarding framework -- idk, but you definitely just want the couple-of-cells version for thisadded type annotations
This PR introduces
plots.ipynb
, which is a no-nonsense way of plotting data collected as part of theloschmidt.tilted_square_lattice
benchmark. It is a stripped-down version ofanalysis-walkthrough.ipynb
.analysis-walkthrough.ipynb
into theanalysis
module.str(processor_record)
instead ofprocessor_id
since SimulatedLocalProcessor's have the same processor_id as their real-life counterparts.@verult @dstrain115