quantumlib / ReCirq

Research using Cirq!
https://quantumai.google/cirq/experiments
Apache License 2.0
275 stars 117 forks source link

[loschmidt] plots.ipynb #272

Closed mpharrigan closed 2 years ago

mpharrigan commented 2 years ago

This PR introduces plots.ipynb, which is a no-nonsense way of plotting data collected as part of the loschmidt.tilted_square_lattice benchmark. It is a stripped-down version of analysis-walkthrough.ipynb.

@verult @dstrain115

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

mpharrigan commented 2 years ago

If so, I wonder if it makes more sense to just add this on as a section at the end of the analysis notebook. This would flow better and also get rid of some of the redundant code.

While there is some redundancy, I see this notebook as solving a completely different use case than the other one. The walkthrough is designed to give the developer some insight into the at times complicated aggregation routines available in the analysis module. It's necessary reading if you want to contribute a new way of slicing and dicing the data.

This other notebook is the final step in routine execution of the algorithmic benchmark. I must admit I have a preference for small, focused notebooks over big ones; but here are some real reasons:

mpharrigan commented 2 years ago

added type annotations