QCQMC Part 5: Add Trial Wavefunction

quantumlib / ReCirq

Research using Cirq!

https://quantumai.google/cirq/experiments

Apache License 2.0

275 stars 117 forks source link

Closed fdmalone closed 4 months ago

fdmalone commented 4 months ago

Add trial wavefunction module.

This is very big and could be split up into several files. WDYT @mpharrigan

fdmalone commented 4 months ago

@mpharrigan / @dstrain115 PTAL

mpharrigan commented 4 months ago

What were you thinking re: splitting it up?

Trial WF basic infrastructure (top of file) trial_wf.py
Functions for getting explicit instantiations (middle of file, e.g. 8 qubit whatever)
Functions for doing the parameter optimization

would be one way

fdmalone commented 4 months ago

Pretty much this yes:

trial_wf (for defs etc + maybe move the optimization function into a factory method)
mode / qubit mappings
optimization

fdmalone commented 4 months ago

optimization might be split too if possible

fdmalone commented 4 months ago

One thing the refactor revealed is a lack of unit tests for quite a few things...

fdmalone commented 4 months ago

@dstrain115 could we merge and I'll follow up to add some more unit tests and fix the CI slowness.

dstrain115 commented 4 months ago

Yeah, that's fine with me.

fdmalone commented 4 months ago

(I can't merge this myself)