quantumlib / ReCirq

Research using Cirq!
https://quantumai.google/cirq/experiments
Apache License 2.0
275 stars 117 forks source link

Move third_party to recirq/third_party #361

Closed fdmalone closed 3 months ago

fdmalone commented 3 months ago

Should fix pip installation within notebooks.

pavoljuhas commented 3 months ago

One more comment - after merging with master the high_level.ipynb notebook fails when trying to read .../site-packages/recirq/qcqmc/data/integrals/fh_sto3g/hamiltonian.chk.

Perhaps that file needs to be added to package_data here? https://github.com/quantumlib/ReCirq/blob/17a5fdef73e0e578eb8df33b2c9f8418630ed88c/setup.py#L56-L61

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

fdmalone commented 3 months ago

@pavoljuhas PTAL I think I resolved everything and verified the notebooks run in a clean environment.