search

quantumlib / qsim

Schrödinger and Schrödinger-Feynman simulators for quantum circuits.
Apache License 2.0
455 stars 153 forks source link

Fix typo in docs #620

Closed eliottrosenberg closed 1 year ago

eliottrosenberg commented 1 year ago

@95-martin-orion Do you know why this is failing Docker / Test on ubuntu-latest (pull_request)?

95-martin-orion commented 1 year ago

@95-martin-orion Do you know why this is failing Docker / Test on ubuntu-latest (pull_request)?

Seems to be from PEP 668, based on this SO question. The way we set up Docker-based CI tests is probably not consistent with modern best practices, and hasn't been updated in a long while - thus the CI decay.

NoureldinYosri commented 1 year ago

The CIs #624 #625 #627 have now been fixed

eliottrosenberg commented 1 year ago

@NoureldinYosri @95-martin-orion Do you know why kokoro is taking so long to run?

95-martin-orion commented 1 year ago

@NoureldinYosri @95-martin-orion Do you know why kokoro is taking so long to run?

That's on me - Kokoro must be manually triggered by someone with write access to the repo applying the label. It should get started now.

eliottrosenberg commented 1 year ago

@95-martin-orion Thanks! Would you be able to merge this? I don't have write access.

95-martin-orion commented 1 year ago

Done. Thank you for the fix!