search

quaquel / EMAworkbench

workbench for performing exploratory modeling and analysis
BSD 3-Clause "New" or "Revised" License
128 stars 90 forks source link

prim: Replace deprecated Altair function #270

Closed EwoutH closed 1 year ago

EwoutH commented 1 year ago

Replace altair.selection_single() with altair.selection_point(), since the former is deprecated in Altair 5.0.0.

Do not merge yet, still running some tests.

Also note that Altair is not covered currently in our CI.

quaquel commented 1 year ago

The reason that its not covered by the CI is that, if I recall correctly, there were a few remaining things in the code I wanted to polish. But then covid came. This is also why I haven't documented it in much detail.

coveralls commented 1 year ago

Coverage Status

Coverage: 81.097%. Remained the same when pulling 6b95801a0293c9b11d1d475c5de528ba8801c9b6 on altair-v5-fix into f7fe968963bb56ae82dbd283a30aaba1244416d5 on master.

EwoutH commented 1 year ago

With 5405cf7 the error got resolved, but apparently that was already outdated (Altair must have a very stable API) so I replaced it in 6b95801 to also remove the new deprecation error. With this PR, it's now error and warning free and it looks likes it behaves like expected.

quaquel commented 1 year ago

Go ahead and merge this if it now is ready to be merged.

EwoutH commented 1 year ago

Done!

We might want to cherry pick this into a 2.5.1 release, I can do that Monday if you agree.

quaquel commented 1 year ago

There is another weird thing in the pca preprocessing that ideally I'll investigate and fix as part of that as well