inspect multiple boxes and display them in a single figure

quaquel / EMAworkbench

workbench for performing exploratory modeling and analysis

BSD 3-Clause "New" or "Revised" License

128 stars 90 forks source link

inspect multiple boxes and display them in a single figure #317

Closed quaquel closed 11 months ago

quaquel commented 1 year ago

closes #124

Adds an optional keyword argument ax to PrimBox.inspect to be used in conjunction with style='graph'. Ax can be a single Axes or a list of Axes instances of the same length as i. If used, each box in i is plotted in separate Axes.

Rather that try to solve the axes layout as suggested in #124, it is left to the user to setup the figure to their liking. See sd_prim_flu.py for an example usage.

coveralls commented 1 year ago

coverage: 80.251% (+0.05%) from 80.206% when pulling 55b5a4432af187960a544dd406d4d58b06b4c831 on inspect_graph into 20025328908142662c01ccec5a27b2f61efefda0 on master.

EwoutH commented 1 year ago

Thanks for implementing this, I will try to review it this week.

quaquel commented 11 months ago

Just a simple reminder that it would be great if you could take a quick look at this so I can merge it.

EwoutH commented 11 months ago

Thanks, I put it on my list for Monday.

To give some context, I'm now really in a hard push to get my thesis started. As always, the things I find most interesting are also the hardest and biggest. Then this requires to get a full overview of the system to properly identify the gaps - and then selecting a feasonable one. So that consumes most of my energy right now.

Also, maybe it would be good to talk about my formal role in the workbench maintenance again. When I was TAing in EPA1361 and after that working on the MPIEvaluator is was a relatively low effort to do it on the side (and a great learning experience - it still is), I now notice takes a bit more effort to switch to it.