search

quaquel / EMAworkbench

workbench for performing exploratory modeling and analysis
BSD 3-Clause "New" or "Revised" License
128 stars 90 forks source link

Fix finalizer dependency on global experiment_runner #346

Closed quaquel closed 8 months ago

quaquel commented 8 months ago

The current finalizer in futures_util.py assumes that experiment_runner exists in the namespace of the module (i.e., .py file). However, this is only available in each of the separate futures models (i.e., multiprocessing, mpi). This fixes the resulting bug.

coveralls commented 8 months ago

Coverage Status

coverage: 80.287% (-0.01%) from 80.3% when pulling 6f7a1b222e9f1ed36e23036a68bcec3ce1c78bf0 on finalizer into ebc96e96ee69fa9c5d5344936a6481e54bfa2fdf on master.

EwoutH commented 8 months ago

Would it be useful to have some more test coverage here?

quaquel commented 8 months ago

Would it be useful to have some more test coverage here?

Yes, I want to still add a test that reproduces the original error. I just needed the fix last week for the pandemic example I was using.