search

quarkiverse / .github

Reusable Workflows
https://docs.github.com/en/actions/administering-github-actions/sharing-workflows-secrets-and-runners-with-your-organization
Apache License 2.0
0 stars 2 forks source link

Release created may not always be the latest #3

Closed gastaldi closed 1 hour ago

gastaldi commented 4 hours ago

Hi! @gastaldi and I just found something. The new release process auto-generates release notes. This new process does not honor SemVer. So for example, if we release a version 3.6.0 and a version 3.5.1 afterwards (which we just did in quarkus-artemis), the later version (i.e. 3.5.1) will be set as latest.

Originally posted by @turing85 in https://github.com/quarkiverse/quarkiverse/discussions/284#discussioncomment-11044571

turing85 commented 4 hours ago

There are two possible (orthogonal) solutions that @gastaldi and I came up with:

  1. Allow users to specify that the current release is or is not the latest version.
  2. parse the current latest version and the version of the actual release performed right now. If actual > current, then set it as latest.
turing85 commented 3 hours ago

While we are at it, we could also try to set a draft version automatically or via configuration.

gsmet commented 2 hours ago

Should we try to see if JReleaser solved the issue already for us?

gastaldi commented 2 hours ago

Should we try to see if JReleaser solved the issue already for us?

That's also another option. Right now we're using JReleaser only to deploy to Central but maybe that could work

gastaldi commented 2 hours ago

@turing85 suggested adding latest and pre-release flags in .github/project.yml and use them in the gh release call

gastaldi commented 2 hours ago

Should we try to see if JReleaser solved the issue already for us?

That's also another option. Right now we're using JReleaser only to deploy to Central but maybe that could work

However, I'm afraid that using JReleaser for that may require more testing as the configuration to achieve that may not be that trivial

gsmet commented 1 hour ago

However, I'm afraid that using JReleaser for that may require more testing as the configuration to achieve that may not be that trivial

Well, I mentioned it because it seems trivial. Not sure how smart it is though.