Closed gastaldi closed 1 month ago
I wonder if using mvn
from the OS won't make the whole a bit undeterministic. Esp. note that moving to Maven 4 may happen soonish. I'd welcome some way to have Maven version explicit: either use mvnw or set the version as a param of the actions?
https://github.com/quarkiverse/.github/blob/main/.github/workflows/prepare-release.yml#L80
Otherwise nice, esp. the trick with having a special job for uploading to central, so that quarkiverse contributors cannot steal the credentials.
I wonder if using
mvn
from the OS won't make the whole a bit undeterministic. Esp. note that moving to Maven 4 may happen soonish. I'd welcome some way to have Maven version explicit: either use mvnw or set the version as a param of the actions?quarkiverse/.github@
main
/.github/workflows/prepare-release.yml#L80
That makes sense, but most repositories do not have mvnw
installed (it's not even included when I run quarkus create extension
BTW). In the script I'll check if mvnw
exists and use that instead (which I believe is better now).
In separate, we could also create PRs adding mvnw
to them and include in the quarkus create extension
generated files
The
release.yml
workflows in each repository should be updated to the following content:release-prepare.yaml
release-perform.yaml
pre-release.yaml
This gives us the flexibility to adapt the release workflow as it's reusable by all Quarkiverse repositories, including, but not limited to, allowing the usage of protected branches during the release