search

quarkiverse / quarkiverse-parent

The parent POM for all Quarkiverse extensions
Apache License 2.0
7 stars 9 forks source link

Release process doesn't create GitHub releases #57

Closed FroMage closed 2 weeks ago

FroMage commented 2 years ago

I followed the release procedure by making a PR bumping the release number and it worked and ended up in Maven Central, but this did not create any release in https://github.com/quarkiverse/quarkus-renarde/releases

Is this normal?

alexeysharandin commented 2 years ago

Hi @FroMage, how you resolve this?

@gastaldi, I think need to update doc about workflow lifecycle. At this moment I try to understand how to trigger "Quarkiverse Pre Release" step in https://github.com/quarkiverse/quarkus-jdbc-sqlite repo. It's not triggered automatically via PR :( . Need your help here.

FroMage commented 2 years ago

I did not resolve this.

gastaldi commented 2 years ago

The release process just performs a mvn release:prepare release:perform, so no GitHub Release is created at the moment (just the tag).

We're improving the process so we're open to feedback

alexeysharandin commented 2 years ago

@gastaldi, what is not described (or maybe I miss) how to trigger pre-release. based on reverse engeneering quarkus-renarde I found what WF for Pre-Release trigerred by creating branch. I propose to update docs and describe whis to minimize dump questions like I has few days ago :)

gastaldi commented 2 years ago

I moved the IMPORTANT note in https://github.com/quarkiverse/quarkiverse/wiki/Release#perform-the-release to its own section:

https://github.com/quarkiverse/quarkiverse/wiki/Release#important

ia3andy commented 2 years ago

I think it's very important that we provide a GH release and a changelog with Quarkiverse extension releases. Like this: https://github.com/getsentry/sentry-java/releases

This is then distributed to dependabot so we can read it when bumping.

ppalaga commented 1 year ago

Any progress on this one @gastaldi ?

gastaldi commented 1 year ago

@ppalaga no news so far. I stopped working on that because there were some bugs that were just fixed in the latest releases, which I never got the time to try again. My latest work is pushed in https://github.com/quarkiverse/quarkiverse-parent/tree/jreleaser

This is still in my TODO list, but because you can create the GitHub release manually (as I do now) it is not a big priority atm.