Support for multiple named connection factories

quarkiverse / quarkus-artemis

Quarkus Artemis extensions

Apache License 2.0

12 stars 13 forks source link

Support for multiple named connection factories #20

Closed NickPaul41 closed 2 years ago

NickPaul41 commented 2 years ago

Feature request similar to https://github.com/amqphub/quarkus-qpid-jms/issues/13

Support for multiple named connection factories similar to Quarkus datasources

https://quarkus.io/guides/datasource#multiple-datasources

middagj commented 2 years ago

Sounds like a good idea. Feel free to implement it. I don't know when I have time to work on it.

turing85 commented 2 years ago

Do we have an idea how to handle this with devservices?

turing85 commented 2 years ago

I have started working on this feature. I think it is mostly done. Missing:

tests
devservices setup for named connections

A review on the work so far is welcome.

middagj commented 2 years ago

Great, could you put in a PR. Makes review easier. One thing I noticed is that you using lambdas. This is not done in Quarkus code anymore due to performance reasons. Could you change Optional.of().map().orElse to normal flow and keep the anonymous classes?

turing85 commented 2 years ago

PR is open. There's still a problem with "detecting" all configured, named connections at compile-time though. And the handling of devservices is still TBD.