search

quarkiverse / quarkus-artemis

Quarkus Artemis extensions
Apache License 2.0
13 stars 13 forks source link

Bump io.quarkiverse:quarkiverse-parent from 15 to 16 #405

Closed dependabot[bot] closed 7 months ago

dependabot[bot] commented 7 months ago

Bumps io.quarkiverse:quarkiverse-parent from 15 to 16.

Release notes

Sourced from io.quarkiverse:quarkiverse-parent's releases.

16

Breaking Changes

  • This release sets the maven.compiler.release to JDK 17. Make sure you have at least JDK 17 configured as the target JDK.

What's Changed

Full Changelog: https://github.com/quarkiverse/quarkiverse-parent/compare/15...16

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
github-actions[bot] commented 7 months ago

🚦Reports for run #971🚦

Reports will be posted here as they get available.

turing85 commented 7 months ago

@gastaldi Could you take a look at the failing pipeline step? The step executes

./mvnw \
  --batch-mode \
  --define skipTests \
  --define no-format \
  package \
  quarkus:go-offline \
  de.qaware.maven:go-offline-maven-plugin:resolve-dependencies

There is no obvious error in the logs; the execution just "stops".

gastaldi commented 7 months ago

@turing85 the link you pointed shows the following error:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project quarkus-artemis-core: Fatal error compiling: error: release version 17 not supported -> [Help 1]

Probably because the maven-compiler-plugin version is enforced and not reused from quarkiverse-parent?

turing85 commented 7 months ago

@turing85 the link you pointed shows the following error:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project quarkus-artemis-core: Fatal error compiling: error: release version 17 not supported -> [Help 1]

Probably because the maven-compiler-plugin version is enforced and not reused from quarkiverse-parent?

lol not seeing the forest in the midst of of all the trees... Yeah, we set the source- and target-version to 11 explicitly: https://github.com/quarkiverse/quarkus-artemis/blob/baf775c536353509a5d67d2ce3cbc18c8d1ad012/pom.xml#L45-L46

This is on our 2.x-branch, so we should build with java 11. @gastaldi Should we then skip all parent-releases >15 for the 2.x branch?

gastaldi commented 7 months ago

This is on our 2.x-branch, so we should build with java 11. @gastaldi Should we then skip all parent-releases >15 for the 2.x branch?

I'd recommend so, yes. That shouldn't be a problem if you override maven.compiler.release with 11 too.

dependabot[bot] commented 7 months ago

Looks like io.quarkiverse:quarkiverse-parent is no longer being updated by Dependabot, so this is no longer needed.