Rock score calculator cannot tolerate deeply un-rock programs (division by 0 error)

quarkiverse / quarkus-bon-jova-rockstar

An implementation of Rockstar as a JVM language

https://codewithrockstar.com/

3 stars 2 forks source link

Rock score calculator cannot tolerate deeply un-rock programs (division by 0 error) #137

Closed holly-cummins closed 7 months ago

holly-cummins commented 7 months ago

If I have this program

say hi

I get this stack trace:

Caused by: java.lang.ArithmeticException: / by zero
    at io.quarkiverse.bonjova.lyrics.LyricsRatingCalculator.calculateLyricsRating(LyricsRatingCalculator.java:38)
    at io.quarkiverse.bonjova.deployment.rockscore.RockScoreCalculator.calculateRockScore(RockScoreCalculator.java:18)
    at io.quarkiverse.bonjova.deployment.BonJovaQuarkusExtensionProcessor.lambda$generateRockFiles$4(BonJovaQuarkusExtensionProcessor.java:145)

hannotify commented 7 months ago

Good point. Solved it. :-)