Closed holly-cummins closed 7 months ago
That is a good point - I could probably make it work by changing the target/lyrics
destination to src/main/resources/lyrics
and putting that location in the .gitignore
. Then already downloaded lyrics could survive an mvn clean
.
I think there's two potential solutions:
I had in mind the second, but making a jar full of song lyrics and putting it on maven central might not be ideal in terms of copyright, in the same way that putting them in our repo wasn't. :)
Solution #3: just expose the lyrics frequencies in the extension, because other than those the app doesn't need anything else.
I notice if I run the quarkus app offline, I get the following failures:
If we baked the lyrics into the extension, the app could run without needing network access. That might make demos more robust.
Obviously, this is only a nice-to-have, and not critical.