quarkiverse / quarkus-bon-jova-rockstar

An implementation of Rockstar as a JVM language
https://codewithrockstar.com/
3 stars 2 forks source link

Do not discard existing fields when we narrow the type of a variable #88

Closed holly-cummins closed 7 months ago

holly-cummins commented 7 months ago

I noticed when testing 1brc that we have a problem reading arrays, sometimes, because of interference with the support for dynamically changing the type of a variable; there's a difference between compatible type changes, when we want to keep the field, and incompatible changes, when we want to throw it out.

I've put in a fix, but we should also add more tests and maybe something overall more robust.