search

quarkiverse / quarkus-cxf

Quarkus CXF Extension to support SOAP based web services.
Apache License 2.0
72 stars 57 forks source link

Move tests passing on a FIPS system #1286

Closed JiriOndrusek closed 3 months ago

JiriOndrusek commented 4 months ago

fixes https://github.com/quarkiverse/quarkus-cxf/issues/1285

  1. Class TransportPolicyTest moved from ws-security-policy to ws-security-policy-fips.
  2. Test CustomEncryptSignPolicyTest was modified to be able to detect FIPS machine and change assertions accordingly.
  3. Added missing EncryptSignPolicyIT.

This solution duplicates several java classes:

I can imagine a different solution avoiding duplicities:

This second solution would:

JiriOndrusek commented 4 months ago

@ppalaga WDYT ^ (second solution)

ppalaga commented 4 months ago

The number of tests failing in FIPS is quite small (only 5 tests are failing). It would be perhaps clearer if those 5 methods would be handled in the same way as CustomEncryptSignPolicyTest to change assertions in case a FIPS machine is present.

Yeah, what you say makes a lot of sense. Sorry for my suggestions in the other direction. I thought it was much more tests to handle. Would you please implement that?

JiriOndrusek commented 3 months ago

Yeah, what you say makes a lot of sense. Sorry for my suggestions in the other direction. I thought it was much more tests to handle. Would you please implement that?

I started working on the change, but I found a weird behavior witch originates in cxf (I think). I reported the bug as https://issues.apache.org/jira/browse/CXF-8986

I pinged @ffang in the cxf issue. I will finish this PR after confirmation whether the behavior is a bug or a feature.

JiriOndrusek commented 3 months ago

Superseded by https://github.com/quarkiverse/quarkus-cxf/pull/1297