search

quarkiverse / quarkus-github-app

Develop your GitHub Apps in Java with Quarkus.
https://docs.quarkiverse.io/quarkus-github-app/dev/index.html
Apache License 2.0
65 stars 29 forks source link

allow to enable security in devmode #619

Open maxandersen opened 5 months ago

maxandersen commented 5 months ago

with ngrok security checks should still work -but for now security is always disabled.

related to #610

gsmet commented 5 months ago

How do you configure things for ngrok exactly?

maxandersen commented 5 months ago

See https://docs.quarkiverse.io/quarkus-ngrok/dev/index.html until and including stable url.

I also use the next step so I don't have to the domain step in every app but is not required.

So in short:

Add ngrok ext. Get auth token and set it (.token) Get stable domain url and set it (.domain)

Run in Quarkus dev.

gsmet commented 2 months ago

Apparently smee.io can also push the rawdata now so we could probably enable security now: https://github.com/probot/smee.io/commit/8c33d74f250c910b3deda2e498b11ade5645c580

gsmet commented 2 months ago

Did some work here but still pending some smee.io changes: https://github.com/quarkiverse/quarkus-github-app/pull/659