quarkiverse / quarkus-github-app

Develop your GitHub Apps in Java with Quarkus.
https://docs.quarkiverse.io/quarkus-github-app/dev/index.html
Apache License 2.0
60 stars 27 forks source link

Allow Github Event ruoting to serve on HTTP Paths other than root #629

Closed ryandens closed 1 week ago

ryandens commented 2 weeks ago

Currently, this extension listens for GitHub Events on the root path of the HTTP server. This is expressed in two locaitons that I'm aware of

I would like to serve this listener from my application which is a GitHub app but also serves other HTTP requests, and the root path of the application is already spoken for. Ideally, i'd like to configure this extension to listen on /github-event, which is where my own GitHub event routing listens currently, but i think it's sensible to allow for any path to be configured. I think this will help those who would like to migrate to this extension an easier path to do so because they may not follow the conventions laid out in this extension.

The Routes class would have to programmatically register the route via an injected vertx router rather than via the @Route annotation, but it seems relatively straightforward.

If you're open to the change, I'd be happy to make a PR to contribute it.

gsmet commented 1 week ago

It perfectly makes sense.

I must admit that I always saw a GitHub App as run separately but it makes perfect sense to be more friendly with additional features.

Even better if you provide a PR :).

ryandens commented 1 week ago

Thanks! We initially also ran it as a separate app but are now seeing benefits from deploying it as part of a more modular monolith.