quarkiverse / quarkus-google-cloud-services

Google Cloud Services Quarkus Extensions
https://docs.quarkiverse.io/quarkus-google-cloud-services/main/index.html
Apache License 2.0
54 stars 33 forks source link

Question - is it required to add reflection-config entries for Firebase notification objects? #417

Closed ygyg70 closed 1 year ago

ygyg70 commented 1 year ago

Firebase notifications with native image didn't otherwise work. Ended up adding entries for the following classes to reflection-config.json: Message.class Notification.class, AndroidConfig.class, AndroidNotification.class, AndroidFcmOptions.class, WebpushConfig.class, WebpushFcmOptions.class, WebpushNotification.class, ApnsConfig.class, ApnsFcmOptions.class, ApsAlert.class, FcmOptions.class, MessagingServiceResponse.class

loicmathieu commented 1 year ago

@ygyg70 I don't understand the question.

Is there missing native image configuration for one of the extension in this repository ?

By the way, Google tries to manage native image configuration in each library, reflective access should be handle on their side so you can open an issue upstream so it will be available for everyone and not just Quarkus users

ygyg70 commented 1 year ago

https://github.com/firebase/firebase-admin-java/issues/800

loicmathieu commented 1 year ago

Great, I'll close it as dependabot will create an update PR when the issue is fixed upstream. Please re-open it if something has to be done at our side except a dependency upgrade.