search

quarkiverse / quarkus-helm

Quarkus Extension to generate the Helm artifacts
Apache License 2.0
11 stars 10 forks source link

Add new annotations in service.yaml #158

Open wgresshoff opened 1 year ago

wgresshoff commented 1 year ago

With expressions it it currently possible to replace the values of existing annotations (there are only two). It would be great if it would be possible to add new ones, too. My use case is networking.istio.io/exportTo which adds support for the Istio ingress (don't know if it's the standard way, in our Kubernetes cluster it's done this way).

Sgitario commented 1 year ago

Unfornately, this is not supported by YamlPath. This tool only supports replacement of values, not adding new values. So, you can't achieve this using configuration. The good thing is that you can provide your custom Service resource with this annotation. See how you can do this: https://quarkus.io/guides/deploying-to-kubernetes#using-existing-resources

Sgitario commented 1 year ago

I won't close this issue, but will add a label "won't fix".

wgresshoff commented 1 year ago

Thanks for your answer, I had that already done as workaround. Sorry to hear it's not possible, I think it would have been a valuable enhancement.