search

quarkiverse / quarkus-helm

Quarkus Extension to generate the Helm artifacts
Apache License 2.0
10 stars 8 forks source link

Fix all asciidoc warnings #262

Closed TheJavaGuy closed 1 year ago

TheJavaGuy commented 1 year ago

Asciidoc interprets strings like ${quarkus-version} as attributes and then issues a WARN during the build that it will skip reference to a missing attribute. This PR adds an inclusion of attributes file to the example-crud.adoc.

Proof of all warnings gone:

image

Proof of warnings before this PR:

image
TheJavaGuy commented 1 year ago

@Sgitario Thank you for the merge! Would it be too much to ask you to add me to contributors for docs via all-contributors bot?

Sgitario commented 1 year ago

@all-contributors add @TheJavaGuy for docs