search

quarkiverse / quarkus-helm

Quarkus Extension to generate the Helm artifacts
Apache License 2.0
10 stars 8 forks source link

Preserve double quotes with values.yaml contain data with spaces #317

Closed Sgitario closed 6 months ago

Sgitario commented 6 months ago

Fixes https://github.com/quarkiverse/quarkus-helm/issues/315

gsmet commented 6 months ago

Maybe it's just me but I would be very surprised if Jackson was outputting invalid Yaml. This seems odd to me.

Sgitario commented 6 months ago

Maybe it's just me but I would be very surprised if Jackson was outputting invalid Yaml. This seems odd to me.

No, the output from Jackson is syntactically correct, it's the Helm client that complains about it.

gsmet commented 6 months ago

Should it be reported to the helm client? Because I would expect it to be able to read standard YAML :).

Sgitario commented 6 months ago

Should it be reported to the helm client? Because I would expect it to be able to read standard YAML :).

Yes, good point. I will check if this issue is already reported and will do if it does not. The Helm client has plenty of limitions, one that annoyed me the most is about parsing strings to integers (this was reported a very while ago).

gsmet commented 6 months ago

Thanks @Sgitario , great work as always :).