search

quarkiverse / quarkus-hivemq-client

Quarkus HiveMQ Client extension
Apache License 2.0
5 stars 5 forks source link

Set icon url to point to a valid image file #214

Closed holly-cummins closed 7 months ago

holly-cummins commented 7 months ago

The icon-url field in quarkus-extension.yaml looks like it points to an image file, but it's actually the HTML landing page that GitHub wraps around the file. Using the raw url will work.

I also noticed that Hive sets an image-url, but also sets a GitHub social media preview. It's not necessary to do both, at least for what renders on http://quarkus.io/extensions. The social media preview is why https://quarkus.io/extensions/io.quarkiverse.hivemqclient/quarkus-hivemq-client/ has a logo, even though the image-url isn't right.

pjgg commented 7 months ago

@dependabot rebase

pjgg commented 7 months ago

close https://github.com/quarkusio/extensions/issues/680

Thank you for your contribution @holly-cummins