search

quarkiverse / quarkus-ironjacamar

IronJacamar is an implementation of the Jakarta Connector Architecture specification
https://docs.quarkiverse.io/quarkus-ironjacamar/dev/index.html
Apache License 2.0
4 stars 2 forks source link

`background-validation-millis` should be a long #124

Closed gastaldi closed 3 months ago

gastaldi commented 3 months ago

a side comment on background-validation-millis: it is a duration. so when you do background-validation-millis=5000, it is interpreted as 5000 seconds not 5. might have been more appropriate to leave the type as long insted of duration.

Originally posted by @vsevel in https://github.com/quarkiverse/quarkus-ironjacamar/issues/123#issuecomment-2273873203

gastaldi commented 3 months ago

Actually, we could keep the Duration and change the config name to background-validation-interval, WDYT @vsevel ?

gastaldi commented 3 months ago

There are other config names that could follow this pattern too

vsevel commented 3 months ago

we could keep the Duration and change the config name to background-validation-interval

that would work too. I was wondering if you wanted to retain the original config names. I suspected that background-validation-millis is the wording used in ironjacamar itself. I fine with both really.