quarkiverse / quarkus-jdbi

Jdbi provides convenient, idiomatic access to relational data in Java
https://jdbi.org/
Apache License 2.0
13 stars 4 forks source link

Fix #83 register constructor mappers #81

Open diversit opened 8 months ago

diversit commented 8 months ago

Fix for issue #83 with the @RegisterConstructorMappers annotation.

Updated construction of ReflectiveClassBuildItem item since the used constructors are all deprecated. Using the recommended builder(...) method.

smil2k commented 8 months ago

@diversit It seems that the test did not passed, does it run on your end?

diversit commented 8 months ago

Tests run fine here but I see the build is running them natively. I cannot run the native build on my Mac so I'm setting up a Ubuntu to be able to reproduce the issue locally.

diversit commented 8 months ago

The test was failing for the native image since the native Quarkus could not startup due to missing proxies. Adding the required proxy config for building the native image solved the issue and now the test runs successfully.

smil2k commented 8 months ago

Thank you for your effort!