quarkiverse / quarkus-jnosql

The Quarkus JNoSql Extension adds support for JNoSQL, an implementation of Jakarta NoSQL.
http://www.jnosql.org/
Apache License 2.0
13 stars 4 forks source link

Added Column NoSQL family support + Cassandra Support #23

Closed dearrudam closed 1 year ago

dearrudam commented 1 year ago

Changes

dearrudam commented 1 year ago

@amoscatelli could you review this PR, please?!

I'd like to congrats you and the Quarkus team that is maintaining this amazing extension!!!

amoscatelli commented 1 year ago

@dearrudam thank you, gonna review now

dearrudam commented 1 year ago

I have a question: when this feature will be available in the Maven Central repo?!

amoscatelli commented 1 year ago

I would like add at least another supported driver before releasing 1.0.4. Can you wait a couple of days ?

dearrudam commented 1 year ago

That's okay!!! Do you want help with adding ArangoDB support?

dearrudam commented 1 year ago

I have another question: Quarkus have Devservices that start-up containers like MongoDB and Redis... do you know how to add this capability for other containers? I mean, it will help many developers to use the quarkus-jnosql extensions because most drivers require at least, in dev mode, their containers running...

amoscatelli commented 1 year ago

If you want to contribute with ArangoDB I can take another one. Or simply pick another one you could be interested into. I want to cover more and more of original JNoSQL drivers.

Regarding your question : that's a good question :-) Dunno if we can use directly testcontainers ...

amoscatelli commented 1 year ago

Or maybe we can contribute and add missing databases to devservices, maybe it's not so hard

dearrudam commented 1 year ago

Yeah! Anyway, I think that we could focus on adding support for more drivers meanwhile we try to figure out how to contribute with adding databases to the Quarkus devservices...

amoscatelli commented 1 year ago

This is the pom.xml of the integration test for orangodb quarkus extension :

https://github.com/apache/camel-quarkus/blob/main/integration-tests/arangodb/pom.xml

It seems I was right, they use testcontainers directly but I still need to study this

dearrudam commented 1 year ago

Yeah... I need to study this too... I think that it will improve the dev experience by providing this capability...

amoscatelli commented 1 year ago

here, this is where they use TestContainers :

https://github.com/apache/camel-quarkus/blob/main/integration-tests/arangodb/src/test/java/org/apache/camel/quarkus/component/arangodb/it/ArangodbTestResource.java