search

quarkiverse / quarkus-jooq

Quarkus Jooq Extension
Apache License 2.0
67 stars 17 forks source link

Update dependencies #89

Closed jdussouillez closed 1 year ago

jdussouillez commented 2 years ago

There are some updates of dependencies pending in the MRs (https://github.com/quarkiverse/quarkus-jooq/pull/81, https://github.com/quarkiverse/quarkus-jooq/pull/87, https://github.com/quarkiverse/quarkus-jooq/pull/88) that would be nice to have because they're a bit old.

Thanks

jdussouillez commented 1 year ago

Any updates ?

jdussouillez commented 1 year ago

I just noticed that the 3.17+ jOOQ versions are not compatible with JDK11 (in Open source edition, it is with the pro versions).

In Open source edition, it must be migrated to 3.16+ only. See https://www.jooq.org/download/versions#oss

For now I guess it's only possible to upgrade the Maven version in JDK 11 (8 currently in pom.xml, pipeline build is run in 11) and update to jOOQ 3.16.11

escay commented 1 year ago

A dependency problem when using jOOQ with Quarkus 3.0.0.Alpha2 I run into is the javax to jakarta package change. My jOOQ code compiles, but running the Quarkus code fails on runtime with:

Caused by: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
    [error]: Build step io.quarkiverse.jooq.deployment.JooqProcessor#build threw an exception: java.lang.NoClassDefFoundError: javax/enterprise/context/ApplicationScoped
    at io.quarkiverse.jooq.deployment.JooqProcessor.createDslContextProducerBean(JooqProcessor.java:117)
    at io.quarkiverse.jooq.deployment.JooqProcessor.build(JooqProcessor.java:83)
    at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
    at java.base/java.lang.reflect.Method.invoke(Method.java:578)
    at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909)
    at io.quarkus.builder.BuildContext.run(BuildContext.java:281)
    at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
    at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
    at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
    at java.base/java.lang.Thread.run(Thread.java:1589)
    at org.jboss.threads.JBossThread.run(JBossThread.java:501)

This might relate to issue #30 where it is stated that the latest jOOQ version no longer depends on javax packages. (In the mean time Quarkus 3 is moving to JPA 3.1: https://github.com/quarkusio/quarkus/issues/26986)

So perhaps updating the dependency to jOOQ v3.16 or newer and changing this plugin code to no longer use javax in JooqProcessor might solve this item as well.

jdussouillez commented 1 year ago

Released in v0.4.0