quarkiverse / quarkus-json-rpc

JsonRPC over WebSocket services with Quarkus
https://docs.quarkiverse.io/quarkus-json-rpc/dev/
Apache License 2.0
2 stars 3 forks source link

Add BuildTime config for websocket path #31

Closed indiealexh closed 2 months ago

indiealexh commented 2 months ago

Related to #30

Enables the use of a customized path for the JsonRPC over WebSockets with:

quarkus.json-rpc.web-sockets.path

Enables the ability to disable JsonRPC over Websockets with:

quarkus.json-rpc.web-sockets.enabled

I added this as JsonRPC does not specify a specific transport, so expanding to transport over other protocols should be considered for the future.

indiealexh commented 2 months ago

May close in favor of path on the annotation in alignment with extensions like websocket-next

indiealexh commented 2 months ago

Great ! Thanks ! I think the adoc will be generated from the JavaDoc in the Config, so you can remove that (we need documentation still, but as soon as that is created the config table should be generated automatically)

I'll do the clean up and mark pr ready.

indiealexh commented 2 months ago

@phillip-kruger Ready for review