Closed holly-cummins closed 2 months ago
Oops, I just saw that @gastaldi had fixed the same issue!
assign
sounds nicer than use
, so it's up to you to decide which term to use 😉
Pardon my English, but if the intention is to use assign
shouldn't it be: assign the WebSocket connection ID to the memory ID
?
UPDATE: probably not, just checked some examples and it's perfectly valid as in "I didn't assign it as a distinguished work of journalism," Charles Nesson said.
I had to think about it, but I think I would say either
... but I agree with @gastaldi that the middle one is a bit awkward and maybe not proper English. And I think I actually like 'use' over 'assign', because it captures a nice little internal thought process for the extension code: 'oh man, I need a web socket id, what can I use, what can I use, umm ... ooh! I found a memory id! cool, I'll use that!'
@holly-cummins Right, I felt use
natural while reading, probably because the previous sentence also uses the same verb, so I went with that ;)
Can you fix the conflict?
@cescoffier I've done that so that this is mergeable if we need it ... but I actually think we should close this and go with @gastaldi's version. So I've done that, too.
I made a guess at the intended meaning, feel free to adjust if I got it wrong!