quarkiverse / quarkus-langchain4j

Quarkus Langchain4j extension
https://docs.quarkiverse.io/quarkus-langchain4j/dev/index.html
Apache License 2.0
119 stars 65 forks source link

Fraud detection by distance is broken #567

Closed iocanel closed 1 month ago

iocanel commented 1 month ago

While working on #566 I realized that our distance based fraud detection is broken. By broken I mean that it constantly calculates as 0 the distance between any pair of cities and thus fails to correctly detect frauds.

I think that the issue has to do with the capabilities of the model. ChatGPT 4 is capable to calculate distances, while 3.5 is not.

geoand commented 1 month ago

In that case, we should probably use the latest OpenAI model

iocanel commented 1 month ago

I verify, that going with gpt-4 solves the issue. I am working on a PR.

iocanel commented 1 month ago

Resolved as of #568