search

quarkiverse / quarkus-logging-json

Quarkus logging extension outputting the logging in json.
Apache License 2.0
62 stars 28 forks source link

Make quarkus-jsonb and quarkus-jackson optionals #282

Closed tms0 closed 5 months ago

tms0 commented 9 months ago

Currently, both quarkus-jackson and quarkus-jsonb are added to the application classpath by the extension. AFAIK, this is not the expected behavior and it seems like a huge issue to me ! The extension should let the final application provides them and detect the available capabilities (jackson or jsonb).

This PR fixes this behavior, quarkus-jackson and quarkus-jsonb are now optionals and will not added to the classpath automatically.

tms0 commented 8 months ago

@gastaldi Do you have any thought about this ?

tms0 commented 5 months ago

Hi @gastaldi,

I would like to remind you about this PR, is there any chance to get it merged soon ?

gastaldi commented 5 months ago

Hi @tms0,

I am not a direct maintainer of this extension, so I was waiting for the @quarkiverse/quarkiverse-logging-json team to act on it. I'll merge it since it seems to make sense