search

quarkiverse / quarkus-logging-json

Quarkus logging extension outputting the logging in json.
Apache License 2.0
62 stars 28 forks source link

Add the new configuration property[enabledJavaTimeModule] #306

Open iqnev opened 1 month ago

iqnev commented 1 month ago

Hi @SlyngDK I have provided a potential fix for this issue https://github.com/quarkiverse/quarkus-logging-json/issues/169

Could you please review it and provide your feedback?

SlyngDK commented 1 month ago

@iqnev I don't like the hard coded register approach. But I can accept some sort of configuration, for which jackson modules to register.

And the issue with modules is not auto registered is only an issue with native? Is there an other way to provide/detect the modules in native build?

iqnev commented 1 month ago

@iqnev I don't like the hard coded register approach. But I can accept some sort of configuration, for which jackson modules to register.

And the issue with modules is not auto registered is only an issue with native? Is there an other way to provide/detect the modules in native build?

@SlyngDK Actually, the current PR offers a fully configurable approach. The issue arises specifically with native mode. I had a brief conversation with @geoand , who mentioned that providing a default bean with JavaTimeModule() within the quarkus-logging-json extension could lead to a conflict with the quarkus-jackson extension