search

quarkiverse / quarkus-logging-json

Quarkus logging extension outputting the logging in json.
Apache License 2.0
63 stars 30 forks source link

update to use default branch from ecosystem #95

Closed maxandersen closed 3 years ago

maxandersen commented 3 years ago

ecosystem are renaming its branch on May 3rd. Please merge this before this date. Details at https://github.com/quarkusio/quarkus/issues/16601 cc @gastaldi

SlyngDK commented 3 years ago

@gastaldi build still fails with issues for sonarqube. Maybe a permanent fix this time 😀

gastaldi commented 3 years ago

@SlyngDK it seems that the secrets are only available if the source branch for the PR comes from the same repo (not from a fork). We'll have to rethink this approach

SlyngDK commented 3 years ago

@gastaldi It is the same issue for branches created by dependabot, in this repo. It will be nice to get this issue fixed.

gastaldi commented 3 years ago

@SlyngDK can you point me to where are you seeing issues for branches created by dependabot? I see the build passes in https://github.com/quarkiverse/quarkus-logging-json/pull/96, for example

SlyngDK commented 3 years ago

@gastaldi That fail original, i have just done a rerun, but same with https://github.com/quarkiverse/quarkus-logging-json/pull/98, which I not have done a rerun on.

gastaldi commented 3 years ago

That's really weird. I followed the instructions in https://sonarcloud.io/project/configuration?analysisMode=GitHubActions&id=quarkiverse_quarkus-logging-json and I see that it passes on the Dependabot PRs in https://sonarcloud.io/project/branches?id=quarkiverse_quarkus-logging-json

gastaldi commented 3 years ago

BTW better merge this PR today, we're changing the default branch to main in https://github.com/quarkusio/quarkus-ecosystem-ci today