search

quarkiverse / quarkus-logging-manager

Quarkus extension that allows you to view the log online and change log levels using a UI
Apache License 2.0
50 stars 16 forks source link

Adapt for quarkus 3.3+ #229

Closed manofthepeace closed 1 year ago

manofthepeace commented 1 year ago

cc @phillip-kruger

This is highly draft. I have removed all things related to UI to just have the endpoints working, as I do not know how to have the rest work. Tests won't pass as the it is checking the ui configs/behaviour, which isn't there anymore but I'd like to get your take on how to make this extension work with quarkus 3.3+.

Thanks..

kevinross commented 1 year ago

@phillip-kruger is there an issue tracking that planned feature somewhere I can subscribe to? I use this in one of my tools and want to track when I'll be able to version bump again (I can't upgrade to the latest release quite yet because of this)

phillip-kruger commented 1 year ago

@kevinross - There is not issue yet, but as soon as I have a gap, I'll start working on this. You can see the discussion on Dev UI todo list here: https://github.com/quarkusio/quarkus/discussions/35178

manofthepeace commented 1 year ago

Thanks for your input @phillip-kruger . Good to know the future plans.

phillip-kruger commented 1 year ago

@kevinross - If you are really desperate, you can try and see if this is working in Quarkus: https://github.com/phillip-kruger/stompee (This is the pre-runner of the streaming log in quarkus). I have not tried it, but it might work...

kevinross commented 1 year ago

@phillip-kruger thanks for the recommendation, although I think I'll see how things play out in quarkus-core since the linked option doesn't maintain a most-recently-emitted ("M-R-E") record list, which I'm using with sentry to attach the list of ExtLogRecords ("ELR", stored in that "M-R-E" list) to reported exceptions (I'm not using the quarkiverse sentry extension so none of my exceptions end up having breadcrumbs from logging, since sentry doesn't get installed into the logger hier IIUC, so I DIY (on steroids: attaching the serialized ELRs as extras to the event) adding those, via this extension and the "M-R-E" list). I'm not waiting for anything else to be implemented in -core, so it's no big deal to hold off until the dust settles (so to speak).

manofthepeace commented 1 year ago

@phillip-kruger is the PR ok?

phillip-kruger commented 1 year ago

Yes sorry, slipped through the cracks.

manofthepeace commented 1 year ago

no worrries. Thanks a lot. Would it be possible to have a release with it? sorry for asking a lot of things!

phillip-kruger commented 1 year ago

Doing one now....

phillip-kruger commented 1 year ago

@all-contributors please add @manofthepeace for code please add @manofthepeace for maintenance

allcontributors[bot] commented 1 year ago

@phillip-kruger

I've put up a pull request to add @manofthepeace! :tada:

phillip-kruger commented 1 year ago

@all-contributors please add @manofthepeace for code

allcontributors[bot] commented 1 year ago

@phillip-kruger

I've put up a pull request to add @manofthepeace! :tada: