Open edeweerd1A opened 1 week ago
I think it might be due to https://github.com/quarkiverse/quarkus-logging-splunk/blob/5c9ec6125d180411f88f7d3146facb18b674023a/pom.xml#L57-L71 . But not sure why we are enforcing that.
Do you still need the Splunk repository there?
Anyway, pinging @gastaldi as he will know more.
@aalmiray looks like this is another validation that can be relaxed in Jreleaser
Pomchecker has a --no-strict
flag that can be used to skip this check. I think JReleaser should have an option to pass additional flags to pomchecker.
Could be done with both artifactOverrides
(targeted) or at the deployer level (global).
For info we need the 2nd repository as com.splunk.logging:splunk-library-javalogging is not published to Maven central (https://github.com/splunk/splunk-library-javalogging/issues/17)
The central
can be removed, but that shouldn't prevent publishing to Central AFAIK, I'll see what I can do
I'll get the fix done in JReleaser this weekend. You'll be able to use it via its early-access
builds for the time being til 1.15.0
is released at the end of the month.
My experience is that if you remove Central, the other repository will be contacted first - which might be slow and annoying.
I wonder if it's possible to shade this dependency in the extension's runtime, then the repository can be removed completely
Well, you will need the repository to download the dependency anyway. Given Andres said he would provide a fix soon, we can probably just wait.
My experience is that if you remove Central, the other repository will be contacted first - which might be slow and annoying.
Indeed you're right:
[INFO] Scanning for projects...
Downloading from splunk: https://splunk.jfrog.io/splunk/ext-releases-local/io/quarkus/quarkus-bom/3.15.0.CR1/quarkus-b
om-3.15.0.CR1.pom
Downloading from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-bom/3.15.0.CR1/quarkus-bom-3.15.0.CR
1.pom
Downloaded from central: https://repo.maven.apache.org/maven2/io/quarkus/quarkus-bom/3.15.0.CR1/quarkus-bom-3.15.0.CR1
.pom (471 kB at 1.9 MB/s)
Indeed you're right:
You'll get used to it :]
Well, you will need the repository to download the dependency anyway.
Yes, but that will be there only while building the binary, then the shade plugin will remove it from the pom.xml (assuming the repository element is moved to the runtime/pom.xml)
Yeah, can't say I'm a big fan of shading. Now I have no idea if this extension is just a small thing with no security issues and a few classes or something that might be problematic in the end.
Well, you will need the repository to download the dependency anyway.
Yes, but that will be there only while building the binary, then the shade plugin will remove it from the pom.xml (assuming the repository element is moved to the runtime/pom.xml)
Rather use the flatten plugin to rewrite the pom to-be-published after shading.
Ready https://github.com/jreleaser/jreleaser/commit/50d491512f1f09bb7a4010e3bdec5bb927e38c4d
Simply set pomchecker's strict
property to false
deploy:
maven:
pomchecker:
strict: false
The split release scripts were merged on the quarkus-logging-splunk Quarkiverse extension. A release was attempted with the new scripts and it does not seem to work:
Here is the link to the failed publication: https://github.com/quarkiverse/quarkiverse-release/actions/runs/11497223021/job/32000478343
Is there something missing from the POM perspective for instance?