quarkiverse / quarkus-micrometer-registry

Quarkus extensions that pull together required/related dependencies for optional micrometer registries.
https://docs.quarkiverse.io/quarkus-micrometer-registry/dev/index.html
Apache License 2.0
21 stars 17 forks source link

Update New Relic Insights to New Relic One #157

Open Dosexe opened 2 years ago

Dosexe commented 2 years ago

I tested the lib for new relic and found out that it connects to New Relic Insights which is deprecated at this moment docs

martinffx commented 2 years ago

Is there any intention to migrate to the new relic micrometer registry?

I've got this extension running and it is succesfully shipping metrics to NR but I cannot find these metrics in the NR One UI.

ebullient commented 2 years ago

see the above issue in the micrometer repo -- I'm just trying to make sure I understand what NR wants to do / will support, etc. I think we should be able to add another meter registry for the NR version (not sure how best to disambiguate)

brunobat commented 2 years ago

PR Is ready for review here: https://github.com/quarkiverse/quarkus-micrometer-registry/pull/178

brunobat commented 2 years ago

@Dosexe the issue has been implemented now. Can we close this issue?

Dosexe commented 2 years ago

@brunobat Hi, I need some time to check how it works

Dosexe commented 2 years ago

@brunobat Hi, again, maybe you can give me an advice how to use quarkus app with a new version? Seems I am either doing something wrong or It is not working for me. I updated my app to the latest quarkus version 2.11.1.Final and added implementation("io.quarkiverse.micrometer.registry:quarkus-micrometer-registry-newrelic-telemetry:2.11.0") Result is

INFO  [com.new.tel.tra.BatchDataSender] (Quarkus Main Thread) BatchDataSender configured with endpoint https://one.newrelic.com
INFO  [com.new.tel.tra.BatchDataSender] (Quarkus Main Thread) BatchDataSender configured to use insights keys

But then I see no any signs of calls to new relic.

brunobat commented 2 years ago

@Dosexe Sorry, This got buried and I only saw it now. Are you using these properties:

quarkus.micrometer.export.newrelic.telemetry.publish=true
quarkus.micrometer.export.newrelic.telemetry.apiKey=fixme
quarkus.micrometer.export.newrelic.telemetry.uri=http://fixme