quarkiverse / quarkus-micrometer-registry

Quarkus extensions that pull together required/related dependencies for optional micrometer registries.
https://docs.quarkiverse.io/quarkus-micrometer-registry/dev/index.html
Apache License 2.0
21 stars 17 forks source link

Feature Request - Default value for OTEL_SERVICE_NAME #276

Open amoscatelli opened 1 year ago

amoscatelli commented 1 year ago

When using otel registry, OTEL_SERVICE_NAME should fall back to application name, if not provided in any other means.

If I don't specify OTEL_SERVICE_NAME I see this in NewRelic :

image

Instead I think this should behave like described in opentelemetry quarkus integration : https://quarkus.io/guides/opentelemetry

image

What do you think ?

amoscatelli commented 1 year ago

Here : https://github.com/quarkiverse/quarkus-micrometer-registry/blob/53fa22d5090846fa888740faeeaf124ea8b000a5/micrometer-registry-otlp/runtime/src/main/java/io/quarkiverse/micrometer/registry/otlp/OtlpConfig.java#L73

But if OTEL_SERVICE_NAME is not set, it should fall back to ${quarkus.application.name}

amoscatelli commented 1 year ago

@ebullient if you agree I can make a PR about this ...

Let me know Thank you

ebullient commented 1 year ago

PRs are always welcome. ;)