search

quarkiverse / quarkus-minio

Minio (https://min.io) Client Quarkus Extension
Apache License 2.0
16 stars 24 forks source link

Allow arbitrary env variables passed to the Min.io Dev Service #321

Closed d135-1r43 closed 3 months ago

d135-1r43 commented 3 months ago

It is best practice to accept arbitrary env variables being passed to the dev service container. Examples for this can be found at the official Quarkus guide on Dev Services. E.g., quarkus.amqp.devservices.container-env."environment-variable-name"

Use case: I want the dev service to be preconfigured with

ENV MINIO_NOTIFY_KAFKA_ENABLE_LOCAL="on"
ENV MINIO_NOTIFY_KAFKA_BROKERS_LOCAL="localhost:55003"

If the feature gets approved, I could do the PR on my own.

jtama commented 3 months ago

Not 100% sure what you want to do. You wan't to be able to setup arbitrary env var that would be passed on to the dev service at startup ? In the example you give, they make use of withEnv("AMQ_EXTRA_ARGS", extra);, how exactcly would you reproduce that ?

Anyhow, please feel free to provide a PR, I would certainly have a better understanding of what you want to achieve.

d135-1r43 commented 3 months ago

I made the PR and used the same pattern as the other extensions are using.

jtama commented 3 months ago

@d135-1r43 many thanks for your involvement, will release soon.