search

quarkiverse / quarkus-minio

Minio (https://min.io) Client Quarkus Extension
Apache License 2.0
16 stars 24 forks source link

Provide MinioAsyncClient instances same as MinioClient #329

Closed vemilyus closed 3 months ago

vemilyus commented 3 months ago

Now this extension also provides MinioAsyncClient beans in addition to the usual MinioClient beans.

I've added also a simple integration test that uses a MinioAsyncClient. It's kinda clunky but that's to be expected when doing reactive stuff.

Also, quarkus-minio.adoc was updated, please check if that is ok, I'm not sure.

Closes #328

vemilyus commented 3 months ago

@jtama Please check if this is alright. I did some refactoring for shared code when creating minio clients (async and otherwise)

vemilyus commented 3 months ago

Many thanks for your work. It's very valuable and appreciated. I've added a few comments and additionally, could you please add documentation here ?

Will do!

vemilyus commented 3 months ago

@jtama Please have a look now ;)

vemilyus commented 3 months ago

Fixed imports and squashed!