search

quarkiverse / quarkus-ngrok

ngrok is a globally distributed reverse proxy fronting your web services running in any cloud or private network, or your machine
https://docs.quarkiverse.io/quarkus-ngrok/dev/index.html
Apache License 2.0
7 stars 7 forks source link

Typo in documentation #142

Closed zakhdar closed 1 month ago

zakhdar commented 1 month ago

Just to declare a small typo in the documentation, in the "Usage" section there is a hyphen missing in the property name "quarkus.ngrok.authtoken" -> "quarkus.ngrok.auth-token". However, a message informs us that the application can't find the property, which puts us on the right track.

And above all, thank you for your contributions

geoand commented 1 month ago

Thanks for reporting!

Would you like to contribute a fix?

zakhdar commented 1 month ago

Why not! I'll have a look at the contribution guide

geoand commented 1 month ago

You can likely just use the GitHub UI to edit https://github.com/quarkiverse/quarkus-ngrok/blob/main/docs/modules/ROOT/pages/index.adoc

melloware commented 1 month ago

Thanks for the fix!

melloware commented 1 month ago

@all-contributors add @zakhdar for docs

allcontributors[bot] commented 1 month ago

@melloware

I've put up a pull request to add @zakhdar! :tada: