Exiting from dev mode can leave ngrok still running

quarkiverse / quarkus-ngrok

ngrok is a globally distributed reverse proxy fronting your web services running in any cloud or private network, or your machine

https://docs.quarkiverse.io/quarkus-ngrok/dev/index.html

Apache License 2.0

7 stars 7 forks source link

Exiting from dev mode can leave ngrok still running #87

Closed kdubb closed 7 months ago

kdubb commented 9 months ago

Sometimes exiting from dev mode will leave the ngrok process running.

I am not sure what the trigger is, it may be due to abnormal exits (e.g. CTRL+C) but it is intermittent. After this happens you usually get an error when the next dev mode is started; but even then sometimes it manages to get more than one ngrok started and prints no message.

geoand commented 9 months ago

Weird... I can't say I know what to do about it :)

melloware commented 8 months ago

I just submitted a PR to bump to the latest NGROK client so maybe its a client related bug that has been fixed.

melloware commented 8 months ago

@kdubb can you try 1.3.0 please and let us know if you still get this issue?

melloware commented 7 months ago

@kdubb will close for now. Report back if its still happening and I can reopen

melloware commented 2 months ago

@all-contributors add @kdubb for bug

allcontributors[bot] commented 2 months ago

@melloware

I've put up a pull request to add @kdubb! :tada: