Support domain - Githubissues

quarkiverse / quarkus-ngrok

ngrok is a globally distributed reverse proxy fronting your web services running in any cloud or private network, or your machine

https://docs.quarkiverse.io/quarkus-ngrok/dev/index.html

Apache License 2.0

7 stars 7 forks source link

Support domain #98

Closed maxandersen closed 7 months ago

maxandersen commented 7 months ago

Why:

by default ngrok serves from a new host/domain on every start of a tunnel. That makes it tedius if you have somethingl like a zulip bot where zulip needs to get updated everytime the endpoint changes.

This change addreses the need by:

Add support for ngrok's notion of domains (--domain) which is useful even for free loaders by following info at https://ngrok.com/blog-post/free-static-domains-ngrok-users

melloware commented 7 months ago

This fixes issue #95 for @raul-and I think?

raul-and commented 7 months ago

This fixes issue #95 for @raul-and I think?

I think it does fix the issue. I've got 2 final exams left so I haven't really done much, next week I will get back to work on the project and I'll test it. Thanks!!

geoand commented 7 months ago

@maxandersen do you have any more changes in the pipeline, or should I go ahead and do a release?

maxandersen commented 7 months ago

+1 on release what is there now. the other fix I have requires some more testing and confirmation that it work on other machines than mine. So go for release :)

geoand commented 7 months ago

👌