Constant names for Enums have changed with 2.2.12

chberger commented 11 months ago

I've updated quarkus-openapi-generator from 2.2.11 to 2.2.12. With that release it seems like constant names for enums will be determined in a different way.

Before version 2.2.12 a value of M123 led to a constant called M123. Now with that PR the enum constant has changed to M_M123.

⚠️ This is a breaking change which I would not expect in a patch update.

I've extended QuarkusJavaClientCodegenTest with two scenarios to showcase the behavior: https://github.com/techspace-de/quarkus-openapi-generator/commit/caac29de1b2e0dd6f1413ef79e8fb94708c9ad34

The last two test parameters will fail:

rg.opentest4j.AssertionFailedError: 
expected: "M123"
 but was: "M_M123"
Expected :"M123"
Actual   :"M_M123"
<Click to see difference>

    at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
    at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
    at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
..

and

rg.opentest4j.AssertionFailedError: 
expected: "MA456"
 but was: "MA_MA456"
Expected :"MA456"
Actual   :"MA_MA456"
<Click to see difference>

    at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
    at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
    at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)

chberger commented 11 months ago

CC @hbelmiro @fjtirado @ricardozanini @mcruzdev