quarkiverse / quarkus-openapi-generator

OpenAPI Generator - REST Client Generator
Apache License 2.0
123 stars 86 forks source link

Fix action comments after building docs #538

Closed ricardozanini closed 1 year ago

ricardozanini commented 1 year ago

Many thanks for submitting your Pull Request :heart:!

Please make sure that your PR meets the following requirements:

How to backport a pull request to a different branch? In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-`, where `` is the name of the branch where the pull request must be backported to (e.g., `backport-quarkus2` to backport the original PR to the `quarkus2` branch). > **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another. Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added. If something goes wrong, the author will be notified and at this point a manual backporting is needed. > **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
hbelmiro commented 1 year ago

@ricardozanini we need backport this to quarkus2 branch, as well as https://github.com/quarkiverse/quarkus-openapi-generator/pull/511, don't we?

github-actions[bot] commented 1 year ago

🎊 PR Preview 66d8b42d566760c5f268e14814db08ea5f76ee79 has been successfully built and deployed to https://quarkus-openapi-generator-preview-pr-538.surge.sh

ricardozanini commented 1 year ago

@ricardozanini we need backport this to quarkus2 branch, as well as #511, don't we?

No, I intend to drop Quarkus 2 support soon. Also not sure how we keep two versions of the doc. I'd rather save the hurdle and not publish at all, just keep the good old README in quarkus2 branch.