quarkiverse / quarkus-openapi-generator

OpenAPI Generator - REST Client Generator
Apache License 2.0
108 stars 68 forks source link

Try to fix upload-artifact@v4 issue #601

Closed mcruzdev closed 6 months ago

mcruzdev commented 6 months ago

Many thanks for submitting your Pull Request :heart:!

Fixes #599.

Please make sure that your PR meets the following requirements:

How to backport a pull request to a different branch? In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-`, where `` is the name of the branch where the pull request must be backported to (e.g., `backport-quarkus2` to backport the original PR to the `quarkus2` branch). > **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another. Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added. If something goes wrong, the author will be notified and at this point a manual backporting is needed. > **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
ricardozanini commented 6 months ago

@mcruzdev I think the variable name is not getting from the matrix var. See: Artifact site-{{ matrix.java.version }}-{{ matrix.os }}.zip successfully finalized. Artifact ID 1129900601

ricardozanini commented 6 months ago

Another improvement, I think we can build only once the website in the preview pipeline. Doesn't make much sense publishing 4 artifacts in each matrix run.

mcruzdev commented 6 months ago

Another improvement, I think we can build only once the website in the preview pipeline. Doesn't make much sense publishing 4 artifacts in each matrix run.

$ sign mistake, TY.

ricardozanini commented 6 months ago

Another improvement, I think we can build only once the website in the preview pipeline. Doesn't make much sense publishing 4 artifacts in each matrix run.

$ sign mistake, TY.

Thank you for fixing it!!

mcruzdev commented 6 months ago

@ricardozanini WYT about creating just one job to generate the site documentation and consume it in preview.

ricardozanini commented 6 months ago

@ricardozanini WYT about creating just one job to generate the site documentation and consume it in preview.

Yes, exactly. We should remove the website upload from the matrix build. The other CI can just build skipping test since it's only interested in the website generation.

mcruzdev commented 6 months ago

Done @ricardozanini :)

hbelmiro commented 6 months ago

Awesome! Thank you very much @mcruzdev ❤️

hbelmiro commented 6 months ago

@all-contributors add @mcruzdev for code and documentation.

allcontributors[bot] commented 6 months ago

@hbelmiro

I've put up a pull request to add @mcruzdev! :tada: