Closed mcruzdev closed 2 months ago
Hi @hbelmiro and @ricardozanini I created the wiremock module, what initial features we need to have to merge to main?
Is it possible to create a branch for wiremock stuff, or just adding an initial feature is ok for now?
đ PR Preview 4cde6cafb57aa09c359781bbccd764330f8973d5 has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-648.surge.sh
@mcruzdev
what initial features we need to have to merge to main?
From us, you're probably the one who knows more about it. I'll let you decide. Is this wiremock support a real need for you as a user? If so, what are the ones you need the most? From those, pick the easiest/fastest to implement.
Is it possible to create a branch for wiremock stuff, or just adding an initial feature is ok for now? IMO, we can add features incrementally (an initial feature is ok), so users can benefit from them ASAP.
Hi @hbelmiro, Thank you!
It help me a lot, I will continue here!
Hi @hbelmiro and @ricardozanini, I think that we can get a first review about this new feature.
I'd rather wait for #482 to be merged first. @carlesarnal will kick my ass if I keep asking him to rebase.
Just a few comments initially, I'll do a better review later.
I switched the extension to experimental
Sound good?
I've added some basic features for starters. It is great for new contributors!
@mcruzdev can you rebase? đ
@mcruzdev are the issues pointed by GH relevant?
@mcruzdev are the issues pointed by GH relevant?
Sorry for delay!
I think we can ignore because are Test classes. makes sense?
Unused class: SchemaReaderTest is not referenced within this codebase. If not used as an external API it should be removed.
Hi @hbelmiro thank you for the reviewing it, I will solve all soon!
@mcruzdev can you please let me know when I can re-review it?
Hi @hbelmiro, I think you can review it now! When all things are ok I will do the squash
Hi @hbelmiro and @ricardozanini I think we can wait for merge this pull request, I am seeing here some projects that does similar things and I am collecting some ideas to use here... Another point is: I am very busy and I think if we merge it we will not have effort to upgrade this module faster. WDYT?
@ricardozanini @hbelmiro This is being labeled as Stale.
@ricardozanini @hbelmiro This is being closed due to inactivity.
Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:
[0.9.x] Subject
How to backport a pull request to a different branch?
In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-