quarkiverse / quarkus-openapi-generator

OpenAPI Generator - REST Client Generator
Apache License 2.0
108 stars 66 forks source link

[issue: #651] Adding initialization for non requiered containers in add/put method #654

Closed boyi01 closed 4 months ago

boyi01 commented 4 months ago

Many thanks for submitting your Pull Request :heart:!

Please make sure that your PR meets the following requirements:

When in the model there is a field, that is for example a list and is not diffined as requierd in the yaml, then in the add method there is no initialization, if this field is null.

Fix it as openapi does it, in each "add" method for a container, generate a check if the container is null, if it's null instantiate a new empty container.

@ricardozanini Is there an option to backport this to 2.2.16? Or should we do this local in our Nexus?

ricardozanini commented 4 months ago

@boyi01 thank you!

Is there an option to backport this to 2.2.16? Or should we do this local in our Nexus?

No, we are likely to release a new 2.4.0 version with the latest bumps and PRs.

ricardozanini commented 4 months ago

@fjtirado I remember you fixed some arrays problem in the past. Is this related?

github-actions[bot] commented 4 months ago

🎊 PR Preview 1c41fa96cb8367445152ac63911fb6226308fb29 has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-654.surge.sh

boyi01 commented 4 months ago

@ricardozanini Oky then we have have release our own Version für Quarkus 3.2 with Java11.

Thank you for the fast responding and the work on this repository.

hbelmiro commented 4 months ago

@all-contributors add @boyi01 for code and test.

allcontributors[bot] commented 4 months ago

@hbelmiro

I've put up a pull request to add @boyi01! :tada: